Skip to content

Conversation

prajjwalkumar17
Copy link
Member

@prajjwalkumar17 prajjwalkumar17 commented Mar 2, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

So previously we were only inserting in dynamic_routing_stats table, after this change we will be doing an Upsert operation instead of directly performing an insert operation.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

The same flow is required, the way we test dynamic routing:

  1. enable SR for a merchant.
  2. set volume of payments to 100 for dynamic routing
  3. make two consecutive payments(insure they end up in terminal state).
  4. check the table dynami_routing stats for entry of both of them.

Screenshot 2025-03-17 at 5 08 53 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 self-assigned this Mar 2, 2025
@prajjwalkumar17 prajjwalkumar17 requested review from a team as code owners March 2, 2025 18:34
Copy link

semanticdiff-com bot commented Mar 2, 2025

@prajjwalkumar17 prajjwalkumar17 marked this pull request as draft March 2, 2025 18:34
@prajjwalkumar17 prajjwalkumar17 marked this pull request as ready for review March 3, 2025 09:54
@prajjwalkumar17 prajjwalkumar17 added the C-refactor Category: Refactor label Mar 18, 2025
@prajjwalkumar17 prajjwalkumar17 added this to the February 2025 Release milestone Mar 18, 2025
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit 68aac34 Mar 21, 2025
20 of 24 checks passed
@Gnanasundari24 Gnanasundari24 deleted the refactor_db_call_for_dynamo branch March 21, 2025 12:28
pixincreate added a commit that referenced this pull request Mar 24, 2025
…lobalpay-fixes

* 'main' of github.com:juspay/hyperswitch:
  feat(connector): [Recurly] Add record back support for recurly [V2] (#7544)
  refactor(webhook): add jwt authenticated endpoint to list unique webhook events for a profile (#7325)
  feat(core): Add three_ds_requestor_app_url in business_profile (#7589)
  feat(refunds): Add refunds diesel model support in V2 API (#7503)
  fix(connector): [globalpay] address 5xx due to deserialization issue when `account_name` is not passed (#7540)
  chore: update production endpoint url for globalPay (#7588)
  feat(connector): [Stripebilling] add record back support for stripebilling (#7561)
  feat(router): Make payment_method_subtype optional in payment_attempt [V2] (#7568)
  fix(connector): RSync voided status mapping in AuthorizeDotNet (#7566)
  chore(version): 2025.03.24.0
  feat(connector): [Coingate] implement refunds  (#7513)
  feat(connectors): [Redsys] add Psync and Rsync support (#7586)
  refactor(connector): [BRAINTREE] Pass email in payment requests (#7591)
  feat(webhook): Return events list and total_count on list initial delivery attempt call (#7243)
  refactor(router): make error_type generic in domain_models inorder to avoid conversion of errors in storage_impl (#7537)
  feat(router): [V2] Return connector customer reference IDs in `CustomerResponse` (#7319)
  feat: core changes for extended authorization (#6766)
  feat(coingate): Add Payment webhooks (#7489)
  refactor(dynamic_routing): change insert operation to upsert for dynamic_routing_stats (#7398)
  feat(connectors): [Redsys] add 3D secure card payment support, including transaction capture, cancellation, and refunds (#7508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(dynamic_routing): change insert operation to upsert for dynamic_routing_stats
5 participants